chore(kernel): bump KERNEL_REV to latest main be4b8687 - #507
chore(kernel): bump KERNEL_REV to latest main be4b8687#507eric-wang-1990 wants to merge 1 commit into
Conversation
Bumps kernel version from 5e5dea91 to be4b8687cdddfe7a95dc0fd764cac11020a545a6 (latest origin/main). This is a superset upgrade: - 5e5dea91 includes kernel#282 (AzureSpM2m napi surface for Azure SP M2M auth) - be4b8687 adds kernel#277 (Windows DriverManager teardown fix) Native build regenerates contract successfully; index.d.ts updated with new U2M token-cache control fields (tokenCacheEnabled, tokenCachePassphrase). The .node binary is gitignored per convention.
GitHub Actions
Failure
GitHub Actions
Failure
GitHub Actions
Failure
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
There was a problem hiding this comment.
Pull request overview
Updates the pinned Databricks SQL kernel revision and refreshes its generated TypeScript contract.
Changes:
- Bumps
KERNEL_REVtobe4b8687. - Adds U2M token-cache configuration fields.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Summary |
|---|---|
native/kernel/index.d.ts |
Adds token-cache configuration fields. |
KERNEL_REV |
Pins the newer kernel revision. |
Suppressed comments (1)
KERNEL_REV:1
- Updating this CI pin does not update the binary used by released Node clients:
native/kernel/index.jsresolves the platform package, whilepackage.jsonandpackage-lock.jsonstill pin every@databricks/databricks-sql-kernel-*dependency to0.2.0; the.nodefiles are not committed. Therefore the Windows teardown fix (and the new native behavior) is exercised only by the ephemeral kernel-e2e build, while installs continue loading the old published binary. Please update the published binary dependency/release flow, or clarify that this revision is CI-only rather than a shipped kernel upgrade.
be4b8687cdddfe7a95dc0fd764cac11020a545a6
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: 1 Low
Clean generated-contract bump — KERNEL_REV → be4b8687 plus a regenerated index.d.ts adding two optional U2M token-cache fields; no lib code changed and the additions are backward-compatible. One low note: the new tokenCacheEnabled/tokenCachePassphrase fields aren't wired through the JS adapter, so they remain unreachable from the connector (likely intentional for a chore bump).
| * restarts). `false` disables on-disk persistence (re-login each fresh | ||
| * process); `true` keeps it enabled. Applies to [`AuthMode::OAuthU2m`]. | ||
| */ | ||
| tokenCacheEnabled?: boolean |
There was a problem hiding this comment.
🔵 Low — The regenerated contract exposes tokenCacheEnabled / tokenCachePassphrase on the native ConnectionOptions, but the JS adapter does not surface or forward them: the OAuthU2m member of KernelNativeConnectionOptions (lib/kernel/KernelAuth.ts) has no such fields, and the U2M arm of buildKernelConnectionOptions only sets oauthRedirectPort, oauthScopes, and oauthClientId. As a result the new kernel U2M token-cache controls are unreachable from the connector — callers get the kernel default (cache enabled) with no way to disable persistence or set a passphrase. This is fine as a pure contract bump, but if surfacing these controls is intended, a follow-up needs to add them to the public/internal ConnectionOptions and map them in the U2M arm. Flagging so the gap is tracked rather than silently assumed wired.
Bumps kernel version from 5e5dea91 to be4b8687cdddfe7a95dc0fd764cac11020a545a6 (latest origin/main). This is a superset upgrade:
Native build regenerates contract successfully; index.d.ts updated with new U2M token-cache control fields (tokenCacheEnabled, tokenCachePassphrase). The .node binary is gitignored per convention.